Re: [RTF] iwmc3200wifi: fix device registration ordering for cfg80211

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 Mar 2011 10:41:53 -0700, Luis R. Rodriguez wrote:
On Fri, Mar 18, 2011 at 6:50 AM, John W. Linville
Does anyone even have this hardware?

I don't think it even exists any more.

So similarly here we can likely hit a case where we hit the double
wiphy_unregister() twice and I think we'd oops. My preference is to
make wiphy_unregister() re-entrant and let us detect when the device
already was unregistered. Johannes?

I don't like that, it encourages sloppy driver writing. Seriously,
why is it so hard to properly write the code?

You can fail during init, or you can properly deregister, and that's
about it, no?

johannes

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux