Re: [PATCH 1/1] ASUS OLED checkpatch, sparse and ABI documentation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 2011-03-16 at 16:53 -0700, Greg KH wrote:
> On Wed, Mar 16, 2011 at 07:44:04PM -0400, Kevyn-Alexandre Parà wrote:
> > From: Kevyn-Alexandre Pare <kapare@xxxxxxxxxxxxxxxxxx>
> > 
> > 
> > Signed-off-by: Kevyn-Alexandre Pare <kapare@xxxxxxxxxxxxxxxxxx>
> > ---
> >  Documentation/ABI/testing/sysfs-class-asus_oled |   94 +++++++++++++++++++++++
> 
> For now, please keep this within the drivers/staging/asus_oled
> directory.  It will be moved out when the driver moves out of this
> directory, we need to be self-contained for now.
> 

ok, I will make the change.

> >  drivers/staging/asus_oled/TODO                  |    3 -
> >  2 files changed, 94 insertions(+), 3 deletions(-)
> >  create mode 100644 Documentation/ABI/testing/sysfs-class-asus_oled
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-class-asus_oled b/Documentation/ABI/testing/sysfs-class-asus_oled
> > new file mode 100644
> > index 0000000..e32ea15
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-class-asus_oled
> > @@ -0,0 +1,94 @@
> > +What:       /sys/class/asus_oled/oled_N/enabled
> > +Date:       November 2008
> > +KernelVersion:  2.6.29
> > +Contact:    Jakub Schmidtke <sjakub@xxxxxxxxx>
> > +Description:
> > +        N is the device number, the first, and probably the only, has  number
> > +        1, so it is /sys/class/asus_oled/oled_1/enabled. The 'enabled' files
> > +        is for reading and writing. You can write 0 or 1 to 'enabled' file,
> > +        which will switch on and off the display. Reading from this file will
> > +        tell you the last status set, either 0 or 1. By default it is 1, so if
> > +        the device was set to 'off', and the computer was rebooted without
> > +        power-off, this file will contain wrong value - because the device is
> > +        off, but hasn't been disabled this time and is assumed to be on...
> > +
> > +        If the display is switched off you also need to run:
> > +        echo 1 > /sys/class/asus_oled/oled_1/enabled
> > +        To switch it off, just use:
> > +        echo 0 > /sys/class/asus_oled/oled_1/enabled
> > +Users:  Costin Grigoras <costing@xxxxxxxxx> http://asusg50oled.sourceforge.net/
> > +
> > +What:       /sys/class/asus_oled/oled_N/picture
> > +Date:       November 2008
> > +KernelVersion:  2.6.29
> > +Contact:    Jakub Schmidtke <sjakub@xxxxxxxxx>
> > +Description:
> > +        To 'picture' file you write pictures to be displayed by the OLED
> > +        device.
> > +        The format of the file:
> > +        <M:WxH>
> > +        00001110010111000
> > +        00010101010101010
> > +        ....
> 
> Is this using the binary sysfs file within the driver?  If not, that
> needs to be changed to do so.
> 

By "binary sysfs file within the driver" do you mean to change the
attribute to "struct bin_attribute"

I'm reading about that on:
14.2.3. Binary Attributes:
http://www.makelinux.net/ldd3/chp-14-sect-2.shtml

I will replace atribute with bin_attribute for enabled and picture sysfs
options with:
device_create_file for sysfs_create_bin_file
device_remove_file for sysfs_remove_bin_file

is there some some doc about that in Documentation or elsewhere? didn't
found it.

Any guidelines?

thx,

Kevyn-Alexandre ParÃ

> thanks,
> 
> greg k-h


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux