On Tue, 2020-02-04 at 07:09 +0000, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote: > > I'll pipe up on this thread too > > > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote: > > > > This driver has been in the tree since 2009 with no real movement to get > > > > it out. Now it is starting to cause build issues and other problems for > > > > people who want to fix coding style problems, but can not actually build > > > > it. > > > > > > > > As nothing is happening here, just delete the module entirely. > > > > > > > > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > > > Cc: David Daney <ddaney@xxxxxxxxxxxxxxxxxx> > > > > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > > > > Cc: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > > > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > > > Cc: YueHaibing <yuehaibing@xxxxxxxxxx> > > > > Cc: Aaro Koskinen <aaro.koskinen@xxxxxx> > > > > Cc: Wambui Karuga <wambui.karugax@xxxxxxxxx> > > > > Cc: Julia Lawall <julia.lawall@xxxxxxx> > > > > Cc: Florian Westphal <fw@xxxxxxxxx> > > > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > > > Cc: Branden Bonaby <brandonbonaby94@xxxxxxxxx> > > > > Cc: "Petr Štetiar" <ynezz@xxxxxxx> > > > > Cc: Sandro Volery <sandro@xxxxxxxxxx> > > > > Cc: Paul Burton <paulburton@xxxxxxxxxx> > > > > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > Cc: Giovanni Gherdovich <bobdc9664@xxxxxxxxx> > > > > Cc: Valery Ivanov <ivalery111@xxxxxxxxx> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > > > Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > > > Please can we keep this driver. We do have platforms using it and we > > would like it to stay around. > > > > Clearly we'll need to sort things out to a point where they build > > successfully. We've been hoping to see this move out of staging ever > > since we selected Cavium as a vendor. > > Great, can you send me a patchset that reverts this and fixes the build > issues and accept maintainership of the code? > Yep will do. On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote: > My advice is to delete all the COMPILE_TEST code. That stuff was a > constant source of confusion and headaches. I was also going to suggest this. Since the COMPILE_TEST has been a source of trouble I was going to propose dropping the || COMPILE_TEST from the Kconfig for the octeon drivers. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
