While in the process of preparing vchiq to support the Raspberry Pi 4, I stumbled upon a bunch of dead code in it. Which this series deletes. Ultimately the idea is to clean up vchiq_bcm2835_arm.c up to a point where it'll be easy to join it with vchiq_arm.c, which IIRC the TODO file states, should be the sole responsible for platform code. With this we'll be able to introduce RPi4's functionality in a cleaner way. Overall it's a 500 line clean up, I tried to keep the patches as small and manageable as possible, but I'd be happy to squash them if you prefer it that way. This was tested on a RPi3-B using the camera and HDMI audio and vchiq_test app. --- Changes since v1: - Reordered patches so as to have all of the suspend/resume state deletion together - Fix bug found by kbuild test robot - move "staging: vc04_services: Get rid of vc_suspend_state in struct vchiq_arm_state" into "staging: vc04_services: Get rid of unused suspend/resume states" Nicolas Saenz Julienne (21): staging: vc04_services: Remove unused variables in struct vchiq_arm_state staging: vc04_services: Get rid of resume_blocked in struct vchiq_arm_state staging: vc04_services: Get rid of resume_blocker completion in struct vchiq_arm_state staging: vc04_services: get rid of blocked_blocker completion in struct vchiq_arm_state staging: vc04_services: Delete blocked_count in struct vchiq_arm_state staging: vc04_services: get rid of vchiq_platform_use_suspend_timer() staging: vc04_services: Get rid of vchiq_platform_paused/resumed() staging: vc04_services: Get rid of vchiq_platform_suspend/resume() staging: vc04_services: Get rid of vchiq_platform_videocore_wanted() staging: vc04_services: Get rid of vchiq_platform_handle_timeout() staging: vc04_services: Get rid of vchiq_on_remote_use_active() staging: vc04_services: Get rid of vchiq_arm_vcsuspend() staging: vc04_services: Get rid of vchiq_check_resume() staging: vc04_services: Delete vc_suspend_complete completion staging: vc04_services: Get rid of unused suspend/resume states staging: vc04_services: Get of even more suspend/resume states staging: vc04_services: Get rid of the rest of suspend/resume state handling staging: vc04_services: Get rid of USE_TYPE_SERVICE_NO_RESUME staging: vc04_services: Delete vchiq_platform_check_suspend() staging: vc04_services: Get rid of vchiq_arm_vcresume()'s signature staging: vc04_services: vchiq_arm: Get rid of unused defines .../interface/vchiq_arm/vchiq_2835_arm.c | 43 -- .../interface/vchiq_arm/vchiq_arm.c | 495 +----------------- .../interface/vchiq_arm/vchiq_arm.h | 76 --- .../interface/vchiq_arm/vchiq_core.c | 16 - .../interface/vchiq_arm/vchiq_core.h | 15 - 5 files changed, 9 insertions(+), 636 deletions(-) -- 2.25.0 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel