On Sat, Dec 14, 2019 at 3:28 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Dec 11, 2019 at 11:27:41AM -0800, Brendan Higgins wrote: > > Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe': > > drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the unspecified dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > > Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > > Saying you reported a problem and then fixed it kind of does a bit of > disservice to the "reported-by:" tag which we normally use only to > credit the people that do not actually fix the problem. > > So in the future, no need for this to be there for patches that you > write yourself. Alright, thanks for spelling that out. I will remember that in the future. Cheers! _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
