On Thu, Jan 23, 2020 at 05:32:58PM +0900, Tetsuhiro Kohada wrote: > From: "Tetsuhiro Kohada" <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Remove 'fs_func struct' and change indirect calls to direct calls. > > The following issues are described in exfat's TODO. > > Create helper function for exfat_set_entry_time () and > > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through the fs_func struc ponters ... > > The fs_func struct was used for switching the helper functions of fat16/fat32/exfat. > Now, it has lost the role of switching, just making the code less readable. > > Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > drivers/staging/exfat/exfat.h | 79 +++++----- > drivers/staging/exfat/exfat_core.c | 214 +++++++++++----------------- > drivers/staging/exfat/exfat_super.c | 119 ++++++++-------- > 3 files changed, 178 insertions(+), 234 deletions(-) What changed from v1? Always put that below the --- line, as the documentation asks you to, so that we know what is happening here. Please fix that up and send a v3. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
