Hi Dan, Thank you for you comments, I'll fix the issues in v2. Also, sorry for the duplicate email, I sent the first email only to you (now I think I'll get it right). On Wed, Jan 15, 2020 at 09:21:56AM +0300, Dan Carpenter wrote: > Add a subsystem prefix to the subject. "Staging: kpc2000:" > I totally forgot about this guideline for staging. > On Tue, Jan 14, 2020 at 10:25:15PM -0300, Felipe Cardoso Resende wrote: > > The way I chose to remove the warning was to define a macro to > > make it clear if a flag will be enable or not. > > > > Let me know if you would prefer it to be done in a different way. > > > > All this should go under the --- cut off because we don't want it in the > final git history. > That makes sense. > > Signed-off-by: Felipe Cardoso Resende <felipecardoso.fcr@xxxxxxxxx> > > --- > ^^^ > > The commit message should be something like. "Sparse complains about > "dubious: x | !y". This patch adds some macros to make Sparse happy and > the code more readable. > I see. > I like the patch. enable_flag_if() is slightly weird because normally > the condition would come first. It feels sort of like Perl or something > to put the condition afterwards. But this patch is very small and self > contained so it's fine. > I totally agree it's not usual to put the condition at the end. I did that so the three macros would start with the flag as the first argument, but after writing the code it seemed to me that it helped to keep the focus in the flag. > Just fix up the subject and the commit message and resend. > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
