Re: [PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 20, 2019 at 09:15:09PM +0000, Malcolm Priestley wrote:
> The driver standard error returns remove bool false conditions.
> 
> Cc: stable <stable@xxxxxxxxxxxxxxx> # v5.3+
> Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx>

Fixes: 07ba60a15843 ("staging: vt6656: clean-up registers initialization error path")

The other part of that bug was fixed silently in commit 987d864a2363
("staging: vt6656: manage error path during device initialization").
I'm quite embarrassed that I didn't catch these during review...  It's
the obvious bug right?  "You have reversed the return values but not
updated any of the callers."  *Egg on my face*.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux