On Tue, Dec 17, 2019 at 04:58:24PM -0600, Aditya Pakki wrote: > In kpc_dma_transfer(), the assertion that priv is NULL is never > satisfied. The two callers of the function, dereference the priv > pointer before the call is executed. This patch removes the > unnecessary BUG_ON call. > > Signed-off-by: Aditya Pakki <pakki001@xxxxxxx> > --- > v1: Replace the recovery code by removing the assertion, as suggested > by Greg Kroah-Hartman. > --- > drivers/staging/kpc2000/kpc_dma/fileops.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c > index cb52bd9a6d2f..61d762535823 100644 > --- a/drivers/staging/kpc2000/kpc_dma/fileops.c > +++ b/drivers/staging/kpc2000/kpc_dma/fileops.c > @@ -49,7 +49,6 @@ static int kpc_dma_transfer(struct dev_private_data *priv, > u64 dma_addr; > u64 user_ctl; > > - BUG_ON(priv == NULL); > ldev = priv->ldev; > BUG_ON(ldev == NULL); ldev is also obviously never NULL so you can remove that at the same time. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
