Steve, Philipp, I'd like one (or both) of you to look over this first. It looks as if the subdev_notifier field of struct csi_state is never used, except by the existing v4l2_async_notifier_unregister() call. If I am right, then the real issue is that that field should be removed. Regards, Hans On 12/11/19 11:59 AM, Rui Miguel Silva wrote: > Hi Chuhong, > Thanks for the patch. > > On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote: >> All drivers in imx call v4l2_async_notifier_cleanup() after unregistering >> the notifier except this driver. >> This should be a miss and we need to add the call to fix it. >> >> Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx> > > Reviewed-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx> > > ------ > Cheers, > Rui >> --- >> drivers/staging/media/imx/imx7-mipi-csis.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c >> index 99166afca071..2bfa85bb84e7 100644 >> --- a/drivers/staging/media/imx/imx7-mipi-csis.c >> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c >> @@ -1105,6 +1105,7 @@ static int mipi_csis_remove(struct platform_device *pdev) >> mipi_csis_debugfs_exit(state); >> v4l2_async_unregister_subdev(&state->mipi_sd); >> v4l2_async_notifier_unregister(&state->subdev_notifier); >> + v4l2_async_notifier_cleanup(&state->subdev_notifier); >> >> pm_runtime_disable(&pdev->dev); >> mipi_csis_pm_suspend(&pdev->dev, true); >> -- >> 2.24.0 >> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
