On Tue, Dec 10, 2019 at 11:48:49PM +0200, Aaro Koskinen wrote: > On Tue, Dec 10, 2019 at 12:15:15PM -0800, Guenter Roeck wrote: > > On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote: > > > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote: > > > > I have no idea :( > > > > > > It's stated in the TODO file you are deleting (visible in your > > > patch): "This driver is functional and supports Ethernet on > > > OCTEON+/OCTEON2/OCTEON3 chips at least up to CN7030." > > > > > > This includes e.g. some D-Link routers and Uniquiti EdgeRouters. You > > > can check from /proc/cpuinfo if you are running on this MIPS SoC. > > > > It also results in "mips:allmodconfig" build failures in mainline > > and is for that reason being marked as BROKEN. Unfortunately, > > misguided attempts to clean it up had the opposite effect. > > This was because of stubs hack added by someone - people who do not run > or care about the hardware can now break it for others with their > silly x86 "compile test"s. Compile tests are nice in theory for finding static analysis bugs but often they introduce static checker false positives because we don't initialize *param variables in the stub functions. And those compat stubs in particular were a headache to review. We broke the build a couple times, but we *almost* broke the build a *lot* of times... regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
