Re: [PATCH RFC 2/6] staging: most: rename core.h to most.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 25, 2019 at 04:51:32PM +0100, Christian Gromm wrote:
> This patch renames the core header file core.h to most.h. The intention
> behind this is to have a meaningful name once this file is moved to the
> /include/linux directory.

Does everything in this .h file have to be exposed to the whole kernel?
Are there any things in here that are local only to the most "core"
code?

If this whole thing is public, you might want to clean up your naming of
some structures:

> +enum mbo_status_flags {

enum most_buffer_status_flags?


> +struct mbo {

struct most_buffer_object?

> +struct core_component {

struct most_core_component?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux