You can't have two patches with the same subject.
On Tue, Dec 03, 2019 at 06:54:49PM +0100, Sven Leykauf wrote:
> Fix indentation so that no line exceeds the 80 character border.
>
> Put the return command one line under the default case, so it looks
> better.
>
> Co-developed-by: Daniel Bauer <daniel.j.bauer@xxxxxx>
> Signed-off-by: Daniel Bauer <daniel.j.bauer@xxxxxx>
> Signed-off-by: Sven Leykauf <sven_leykauf1@xxxxxx>
> ---
> drivers/staging/pi433/rf69.c | 56 ++++++++++++++++++++++++------------
> 1 file changed, 37 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 6b13f92028c7..6cdd46682aa9 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -596,42 +596,60 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
> {
> switch (flag) {
> case mode_switch_completed:
> - return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_MODE_READY);
> + return (rf69_read_reg(spi, REG_IRQFLAGS1) &
> + MASK_IRQFLAGS1_MODE_READY);
This isn't how we align things. The ( and the next line should match.
return (rf69_read_reg(spi, REG_IRQFLAGS1) &
MASK_IRQFLAGS1_MODE_READY);
But actually the original is probably better than the new version so
lets just leave it as is.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
