On Wed, Nov 27, 2019 at 10:13:31AM -0800, Travis Davies wrote:
> This patch renames camelcase variable 'ShortData' to 'short_data'
> Fixes checkpatch message 'CHECK: Avoid CamelCase: <ShortData>
>
> Signed-off-by: Travis Davies <tdavies@xxxxxxxxxxxxxxx>
>
> ---
> drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging/rtl8192e/rtl819x_BA.h
> index 8b6e4c26f0fb..34d66b8f5155 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BA.h
> +++ b/drivers/staging/rtl8192e/rtl819x_BA.h
> @@ -20,7 +20,7 @@
> #define DELBA_REASON_UNKNOWN_BA 38
> #define DELBA_REASON_TIMEOUT 39
> union sequence_control {
> - u16 ShortData;
> + u16 short_data;
> struct {
> u16 FragNum:4;
> u16 SeqNum:12;
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 816d31c1d5c7..4d3dac55e189 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -61,7 +61,7 @@ void ResetBaEntry(struct ba_record *pBA)
> pBA->BaParamSet.shortData = 0;
> pBA->BaTimeoutValue = 0;
> pBA->DialogToken = 0;
> - pBA->BaStartSeqCtrl.ShortData = 0;
> + pBA->BaStartSeqCtrl.short_data = 0;
What does the name short data mean? It seems like this is not used
anywhere or the patch would cause a compile error.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
