Re: [PATCH v2] staging: octeon: fix missing a blank line after declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I would like to reiterate my opinion that this checkpatch warning is
bullshit.  For large functions, sure.  For this kind of function, it's
a waste of space.

On Fri, Nov 08, 2019 at 02:23:29PM +0000, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank line after declarations"
> Issue found by checkpatch.pl
> 
> Signed-off-by: Valery Ivanov <ivalery111@xxxxxxxxx>
> ---
> Changes in v2:
>   - fix huge indentation in commit message
> ---
>  drivers/staging/octeon/octeon-stubs.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index d53bd801f440..ed9d44ff148b 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1375,6 +1375,7 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
>  	int port)
>  {
>  	union cvmx_gmxx_rxx_rx_inbnd r;
> +
>  	r.u64 = 0;
>  	return r;
>  }
> -- 
> 2.17.1
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux