On Thu, Oct 31, 2019 at 01:31:39PM +0100, Roi Martin wrote: > diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c > index f71235c6a338..f4f82aecc05d 100644 > --- a/drivers/staging/exfat/exfat_core.c > +++ b/drivers/staging/exfat/exfat_core.c > @@ -713,8 +713,8 @@ static s32 __load_upcase_table(struct super_block *sb, sector_t sector, > > u32 checksum = 0; > > - upcase_table = p_fs->vol_utbl = kmalloc(UTBL_COL_COUNT * sizeof(u16 *), > - GFP_KERNEL); > + upcase_table = kmalloc_array(UTBL_COL_COUNT, sizeof(u16 *), GFP_KERNEL); > + p_fs->vol_utbl = upcase_table; This patch is fine, but one idea for future patches is that you could remove the "upcase_table" variable and use "p_fs->vol_utbl" everywhere instead. > if (!upcase_table) > return -ENOMEM; regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
