On Mon, 2019-10-28 at 11:01 +0300, Dan Carpenter wrote: > On Fri, Oct 25, 2019 at 06:50:25PM -0700, Joe Perches wrote: > > On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote: > > > Fix alignment should match open parenthesis.Issue found by checkpatch. > > > > Beyond doing style cleanups, please always try > > to make the code more readable. > > > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c > > [] > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv, > > > precvbuf->ref_cnt = 0; > > > precvbuf->adapter = padapter; > > > list_add_tail(&precvbuf->list, > > > - &(precvpriv->free_recv_buf_queue.queue)); > > > + &(precvpriv->free_recv_buf_queue.queue)); > > > > Please remove the unnecessary parentheses too > > > > Removing the parentheses increases your chance of the patch being > rejected on the one thing per patch rule... Which for people that actually know how to read and write code is a silly rule. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
