On Thu, 24 Oct 2019 10:59:04 -0700, Matthew Wilcox said: > Wouldn't it be better to do this as: > Patch 1: Change all these defines to -Exxx and remove the stupid errno-changing > blocks like this: Well, except for the fact that the one for FFS_MEDIAERR required splitting the uses into -ENODEV, -EIO, and -ENOENT. Also, "and remover the stupid blocks" would be a second change, and I *thought* the rule was "one thing, one patch". > That way nobody actually needs to review patches 2-n; all of the changes > are done in patch 1. Reviewing a patch where you know that exactly one thing is supposed to happen means scrolling through 14 occurrences of the pattern if (num_alloced == 0) - ret = FFS_FULL; + ret = -ENOSPC; goes *really* fast, and those comprise most of the bulk of the patchset. And as I already mentioned, the "stupid looking blocks" will be removed in a future patch.
Attachment:
pgpXlQcOAiXJ8.pgp
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
