On Thu, Oct 24, 2019 at 07:26:59AM +0200, Julia Lawall wrote: > > If you're making significant changes to this driver, please test them > > using the MIPS cavium_octeon_defconfig which is where this driver is > > actually used. > > > > This driver has broken builds a few times recently which makes me very > > tempted to ask that we stop allowing it to be built with COMPILE_TEST. > > The whole octeon-stubs.h thing is a horrible hack anyway... > > Wambui, > > Please figure out what went wrong here. Are there two sets of typedefs > that should have been updated? > I managed to reproduce these build errors and finally noticed that the "octeon-stubs.h" header is only included when CONFIG_CAVIUM_OCTEON_SOC is not defined, therefore compiling properly for COMPILE_TEST but will actually fail when compiled with CONFIG_CAVIUM_OCTEON_SOC is set since the functions will try to use the definitions in arch/mips/include/asm/octeon/ that don't have the changes. Paul, please tell me if this is correct? Thanks, wambui > Others, > > Would it be reasonable to put the information about how the driver should > be compied in the TODO file? git grep cavium_octeon_defconfig in the > octeon directory turns up nothing. > > thanks, > julia > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1910240722070.2771%40hadrien. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
