On Monday 21 October 2019 14:24:49 CEST Jules Irenge wrote:
> Remove unnecessary void pointers.
> Issue detected and solved by coccinelle tool.
> semantic use
> @@expression e ;@@
> -(void*)(e)
> +e
>
> Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx>
> ---
> drivers/staging/wfx/bh.c | 2 +-
> drivers/staging/wfx/bus_sdio.c | 2 +-
> drivers/staging/wfx/bus_spi.c | 2 +-
> drivers/staging/wfx/sta.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
> index 955ed3a1dd73..d7ad9227c9c4 100644
> --- a/drivers/staging/wfx/bh.c
> +++ b/drivers/staging/wfx/bh.c
> @@ -76,7 +76,7 @@ static int rx_helper(struct wfx_dev *wdev, size_t read_len, int *is_cnf)
> hif = (struct hif_msg *)skb->data;
> WARN(hif->encrypted & 0x1, "unsupported encryption type");
> if (hif->encrypted == 0x2) {
> - if (wfx_sl_decode(wdev, (void *)hif)) {
> + if (wfx_sl_decode(wdev, hif)) {
> dev_kfree_skb(skb);
> // If frame was a confirmation, expect trouble in next
> // exchange. However, it is harmless to fail to decode
> diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c
> index 375e07d6d9ae..237a19b5fd16 100644
> --- a/drivers/staging/wfx/bus_sdio.c
> +++ b/drivers/staging/wfx/bus_sdio.c
> @@ -66,7 +66,7 @@ static int wfx_sdio_copy_to_io(void *priv, unsigned int reg_id,
> if (reg_id == WFX_REG_IN_OUT_QUEUE)
> sdio_addr |= bus->buf_id_tx << 7;
> // FIXME: discards 'const' qualifier for src
> - ret = sdio_memcpy_toio(bus->func, sdio_addr, (void *)src, count);
> + ret = sdio_memcpy_toio(bus->func, sdio_addr, src, count);
> if (!ret && reg_id == WFX_REG_IN_OUT_QUEUE)
> bus->buf_id_tx = (bus->buf_id_tx + 1) % 32;
>
> diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus_spi.c
> index ab0cda1e124f..bd74801e7461 100644
> --- a/drivers/staging/wfx/bus_spi.c
> +++ b/drivers/staging/wfx/bus_spi.c
> @@ -90,7 +90,7 @@ static int wfx_spi_copy_to_io(void *priv, unsigned int addr,
> struct wfx_spi_priv *bus = priv;
> u16 regaddr = (addr << 12) | (count / 2);
> // FIXME: use a bounce buffer
> - u16 *src16 = (void *)src;
> + u16 *src16 = src;
> int ret, i;
> struct spi_message m;
> struct spi_transfer t_addr = {
> diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
> index 688586e823c0..842158b7e805 100644
> --- a/drivers/staging/wfx/sta.c
> +++ b/drivers/staging/wfx/sta.c
> @@ -896,7 +896,7 @@ static int wfx_upload_beacon(struct wfx_vif *wvif)
> /* TODO: Distill probe resp; remove TIM and any other beacon-specific
> * IEs
> */
> - mgmt = (void *)skb->data;
> + mgmt = skb->data;
> mgmt->frame_control =
> cpu_to_le16(IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_PROBE_RESP);
>
Hello Jules,
Thank you for your work.
Did you check that the code continue to compile without warnings after
applying this patch?
--
Jérôme Pouiller
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
