[driver-core:device_h_splitup 11/11] include/linux/device_printk.h:106:2: warning: this statement may fall through

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_h_splitup
head:   965681d8272ce30aa68375c25c4c797731e18dd3
commit: 965681d8272ce30aa68375c25c4c797731e18dd3 [11/11] device.h: move dev_printk()-like functions to device_printk.h
config: powerpc-mpc512x_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 965681d8272ce30aa68375c25c4c797731e18dd3
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15:0,
                    from include/linux/acpi.h:15,
                    from include/linux/i2c.h:13,
                    from include/uapi/linux/fb.h:6,
                    from include/linux/fb.h:6,
                    from drivers/video/fbdev/fsl-diu-fb.c:20:
   drivers/video/fbdev/fsl-diu-fb.c: In function 'fsl_diu_ioctl':
>> include/linux/device_printk.h:106:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
     _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro 'dev_warn'
      dev_warn(info->dev,
      ^~~~~~~~
   drivers/video/fbdev/fsl-diu-fb.c:1290:2: note: here
     case MFB_SET_PIXFMT:
     ^~~~
   In file included from include/linux/device.h:15:0,
                    from include/linux/acpi.h:15,
                    from include/linux/i2c.h:13,
                    from include/uapi/linux/fb.h:6,
                    from include/linux/fb.h:6,
                    from drivers/video/fbdev/fsl-diu-fb.c:20:
>> include/linux/device_printk.h:106:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
     _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro 'dev_warn'
      dev_warn(info->dev,
      ^~~~~~~~
   drivers/video/fbdev/fsl-diu-fb.c:1299:2: note: here
     case MFB_GET_PIXFMT:
     ^~~~
--
   In file included from include/linux/device.h:15:0,
                    from include/linux/acpi.h:15,
                    from include/linux/i2c.h:13,
                    from include/uapi/linux/fb.h:6,
                    from include/linux/fb.h:6,
                    from drivers/video//fbdev/fsl-diu-fb.c:20:
   drivers/video//fbdev/fsl-diu-fb.c: In function 'fsl_diu_ioctl':
>> include/linux/device_printk.h:106:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
     _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/video//fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro 'dev_warn'
      dev_warn(info->dev,
      ^~~~~~~~
   drivers/video//fbdev/fsl-diu-fb.c:1290:2: note: here
     case MFB_SET_PIXFMT:
     ^~~~
   In file included from include/linux/device.h:15:0,
                    from include/linux/acpi.h:15,
                    from include/linux/i2c.h:13,
                    from include/uapi/linux/fb.h:6,
                    from include/linux/fb.h:6,
                    from drivers/video//fbdev/fsl-diu-fb.c:20:
>> include/linux/device_printk.h:106:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
     _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/video//fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro 'dev_warn'
      dev_warn(info->dev,
      ^~~~~~~~
   drivers/video//fbdev/fsl-diu-fb.c:1299:2: note: here
     case MFB_GET_PIXFMT:
     ^~~~

vim +106 include/linux/device_printk.h

    91	
    92	/*
    93	 * #defines for all the dev_<level> macros to prefix with whatever
    94	 * possible use of #define dev_fmt(fmt) ...
    95	 */
    96	
    97	#define dev_emerg(dev, fmt, ...)					\
    98		_dev_emerg(dev, dev_fmt(fmt), ##__VA_ARGS__)
    99	#define dev_crit(dev, fmt, ...)						\
   100		_dev_crit(dev, dev_fmt(fmt), ##__VA_ARGS__)
   101	#define dev_alert(dev, fmt, ...)					\
   102		_dev_alert(dev, dev_fmt(fmt), ##__VA_ARGS__)
   103	#define dev_err(dev, fmt, ...)						\
   104		_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
   105	#define dev_warn(dev, fmt, ...)						\
 > 106		_dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
   107	#define dev_notice(dev, fmt, ...)					\
   108		_dev_notice(dev, dev_fmt(fmt), ##__VA_ARGS__)
   109	#define dev_info(dev, fmt, ...)						\
   110		_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
   111	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux