On Tue, Oct 15, 2019 at 07:40:53PM +0800, YueHaibing wrote: > Null check before kfree is redundant, so remove it. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c > index 7011c2a..4597f4f 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > @@ -2210,8 +2210,7 @@ void rtw_free_hwxmits(struct adapter *padapter) > struct xmit_priv *pxmitpriv = &padapter->xmitpriv; > > hwxmits = pxmitpriv->hwxmits; > - if (hwxmits) > - kfree(hwxmits); > + kfree(hwxmits); Just do: kfree(pxmitpriv->hwxmits); regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
