On Sun, Oct 13, 2019 at 08:06:14PM +0200, Julia Lawall wrote: > > > On Sun, 13 Oct 2019, Wambui Karuga wrote: > > > Use the DIV_ROUND_UP macro to replace open-coded divisor calculation > > to improve readability. > > Issue found using coccinelle: > > @@ > > expression n,d; > > @@ > > ( > > - ((n + d - 1) / d) > > + DIV_ROUND_UP(n,d) > > | > > - ((n + (d - 1)) / d) > > + DIV_ROUND_UP(n,d) > > ) > > > > Signed-off-by: Wambui Karuga <wambui.karugax@xxxxxxxxx> > > --- > > drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > > index 87535a4c2e14..74312e8bb32e 100644 > > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > > @@ -4158,7 +4158,8 @@ void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val) > > > > /* The value of ((usNavUpper + HAL_NAV_UPPER_UNIT_8723B - 1) / HAL_NAV_UPPER_UNIT_8723B) */ > > /* is getting the upper integer. */ > > It's a nice change. Maybe the above comment could also be dropped, since > the code is more understandable now. > > julia > Ok, I agree. Will update this. wambui karuga _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
