On Fri, Oct 11, 2019 at 09:02:39AM +0300, Wambui Karuga wrote: > -typedef union { > +union cvmx_helper_link_info_t { I agree with Julia, all of the "_t" needs to be dropped as that is pointless. It's a holdover from the original name where "_t" was trying to say that this is a typedef. Gotta love abuse of hungarian notation :( Please redo this patch series and resend. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel