Hi Dan Carpenter,
This is a bug, I'll fix it right now.
The coding is much nicer than before, thanks for your comments,
it is very helpful for me.
Thanks,
Xin
On Thu, Oct 10, 2019 at 12:56:17PM +0300, Dan Carpenter wrote:
> On Thu, Oct 10, 2019 at 12:53:15PM +0300, Dan Carpenter wrote:
> > This code is *so* much nicer than before. I hope you feel good about
> > the changes. It makes me happy to look at this code now.
> >
> > On Thu, Oct 10, 2019 at 09:34:19AM +0000, Xin Ji wrote:
> > > +static int edid_read(struct anx7625_data *ctx,
> > > + u8 offset, u8 *pblock_buf)
> > > +{
> > > + int ret, cnt;
> > > + struct device *dev = &ctx->client->dev;
> > > +
> > > + for (cnt = 0; cnt < EDID_TRY_CNT; cnt++) {
> ^^^^^
>
> > > + sp_tx_aux_wr(ctx, offset);
> > > + /* set I2C read com 0x01 mot = 0 and read 16 bytes */
> > > + ret = sp_tx_aux_rd(ctx, 0xf1);
> > > +
> > > + if (ret) {
> > > + sp_tx_rst_aux(ctx);
> > > + DRM_DEV_DEBUG_DRIVER(dev, "edid read failed, reset!\n");
> > > + cnt++;
> ^^^^^
>
> I mean that it's incremented twice, yeah?
>
> regards,
> dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
