On Mon, Oct 07, 2019 at 06:15:23PM +0200, Thomas Meyer wrote: > Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > > > On Sun, Oct 06, 2019 at 04:07:45PM +0200, Thomas Meyer wrote: > >> Use lib/crc32 instead of another implementation. > >> > >> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx> > > > > I always get annoyed whenever anyone asks if people have tested their > > patches, but have you tested this? > > no annoynence on my side, but... :-) > > Good question. I tell you what I did and then you tell me if I did test! > > So I did this: I did write a small C program that does contain a small > byte buffer and the extracted CRC32 logic from the wlan driver. > The program does calculate the CRC32 sum with the extracted logic and by > calling crc32_le function. but values are the same. > > But as I don't own the hardware I couldn't do a real test with WEP (as > far as I understand only WEP on this hardware would be affected.) > > So a better test would be to find someone which actually owns the > hardware and could test the change. > > so... what do you think? Could you send your test program? Anyway your testing sounds reasonable so I'm fine with this change. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
