On Tue, Sep 24, 2019 at 8:47 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote: > > Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter. > > Please wrap your lines at 72 columns. > > I will keep this in mind. I was under the impression that the line length must be 80 columns but will make the change immediately. To be able to wrap the lines, maybe code implementation needs to be changed slightly as there is a lot of nesting present in the current code? > > > > > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Signed-off-by: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx> > > --- > > drivers/staging/rtl8192u/r8190_rtl8256.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Why was this resent? What changed from the 1st one that caused this to > be required to be resent? > > Now you owe me a v2 of this patch with the changelog text fixed up :) > > thanks, > > greg k-h I actually did not know that the merge window was closed, and thought this patch may have been missed as I did not get any reply. So I resent it as it was following the instructions here(https://kernelnewbies.org/Outreachyfirstpatch) Should I send a v2 with the changelog stating the same? regards, Sumera _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
