> On 7 Sep 2019, at 16:39, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > You need a subject prefix. It should be something like: > > [PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c > Thanks for the reply! I'll try to do that better for my next patch. > Generally "Fix" is considered better style than "Fixed". We aren't > going to care about that in staging, but the patch prefix is mandatory > so you will need to redo it anyway and might as well fix that as well. > >> On Fri, Sep 06, 2019 at 08:38:01PM +0200, volery wrote: >> There were some parentheses at the end of lines, which I took care of. >> This is my first patch. > ^^^^^^^^^^^^^^^^^^^^^^ > Put this sort of comments after the --- cut off line > >> >> Signed-off-by: Sandro Volery <sandro@xxxxxxxxxx> >> --- > ^^^ > Put it here. It will be removed when we apply the patch so it won't > be recorded in the git log. > Alright :) >> drivers/staging/gasket/apex_driver.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Joe's comments are, of course, correct as well. > > regards, > dan carpenter > I'll take a look at Joe's suggestions too sometime tonight. I'd feel kinda bad tho if I just apply his work and send it in? - Sandro Volery _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
