From: Valentin Vidic > Sent: 03 September 2019 19:12 > On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > > + } else if (uni == 0xFFFF) { > > > skip = TRUE; > > > > While we are at it, could you get rid of that 'TRUE' macro? > > Sure, but maybe in a separate patch since TRUE/FALSE has more > calls than just this. I bet you can get rid of the 'skip' variable and simplify the code by using continue/break/return (or maybe goto). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel