You can drop the if on line 3490.
julia
---------- Forwarded message ----------
Date: Tue, 3 Sep 2019 04:28:35 +0800
From: kbuild test robot <lkp@xxxxxxxxx>
To: kbuild@xxxxxx
Cc: Julia Lawall <julia.lawall@xxxxxxx>
Subject: [staging:staging-testing 268/273]
drivers/staging/exfat/exfat_super.c:3491:2-7: WARNING: NULL check before
some freeing functions is not needed.
CC: kbuild-all@xxxxxx
CC: devel@xxxxxxxxxxxxxxxxxxxx
TO: "Valdis Kl??tnieks" <valdis.kletnieks@xxxxxx>
CC: "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>
CC: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head: 544b3e7fd2d39b571298c64000423df21b912a3b
commit: c48c9f7ff32b8b3965a08e40eb6763682d905b5d [268/273] staging: exfat: add exfat filesystem code to staging
:::::: branch date: 2 hours ago
:::::: commit date: 4 days ago
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Reported-by: Julia Lawall <julia.lawall@xxxxxxx>
>> drivers/staging/exfat/exfat_super.c:3491:2-7: WARNING: NULL check before some freeing functions is not needed.
--
>> drivers/staging/exfat/exfat_super.c:2699:26-33: WARNING opportunity for kmemdup
git remote add staging https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout c48c9f7ff32b8b3965a08e40eb6763682d905b5d
vim +3491 drivers/staging/exfat/exfat_super.c
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3487
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3488 static void exfat_destroy_inode(struct inode *inode)
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3489 {
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3490 if (EXFAT_I(inode)->target)
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 @3491 kfree(EXFAT_I(inode)->target);
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3492 EXFAT_I(inode)->target = NULL;
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3493
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3494 kmem_cache_free(exfat_inode_cachep, EXFAT_I(inode));
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3495 }
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 3496
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
