Hi, This patchset is based on the following patch by Pratik Shinde, https://lore.kernel.org/linux-erofs/20190830095615.10995-1-pratikshinde320@xxxxxxxxx/ All patches addressing Christoph's comments on v6, which are trivial, most deleted code are from erofs specific fault injection, which was followed f2fs and previously discussed in earlier topic [1], but let's follow what Christoph's said now. Comments and suggestions are welcome... [1] https://lore.kernel.org/r/1eed1e6b-f95e-aa8e-c3e7-e9870401ee23@xxxxxxxxxx/ Thanks, Gao Xiang Gao Xiang (21): erofs: remove all the byte offset comments erofs: on-disk format should have explicitly assigned numbers erofs: some macros are much more readable as a function erofs: kill __packed for on-disk structures erofs: update erofs_inode_is_data_compressed helper erofs: kill erofs_{init,exit}_inode_cache erofs: use erofs_inode naming erofs: update comments in inode.c erofs: update erofs symlink stuffs erofs: kill is_inode_layout_compression() erofs: use dsb instead of layout for ondisk super_block erofs: kill verbose debug info in erofs_fill_super erofs: simplify erofs_grab_bio() since bio_alloc() never fail erofs: kill prio and nofail of erofs_get_meta_page() erofs: kill __submit_bio() erofs: kill magic underscores erofs: use a switch statement when dealing with the file modes erofs: add "erofs_" prefix for common and short functions erofs: kill all erofs specific fault injection erofs: kill use_vmap module parameter erofs: save one level of indentation Documentation/filesystems/erofs.txt | 9 -- fs/erofs/Kconfig | 7 -- fs/erofs/data.c | 62 +++------- fs/erofs/decompressor.c | 34 ++--- fs/erofs/dir.c | 6 +- fs/erofs/erofs_fs.h | 162 ++++++++++++------------ fs/erofs/inode.c | 176 +++++++++++++------------- fs/erofs/internal.h | 156 +++-------------------- fs/erofs/namei.c | 12 +- fs/erofs/super.c | 185 ++++++++-------------------- fs/erofs/xattr.c | 33 +++-- fs/erofs/xattr.h | 4 +- fs/erofs/zdata.c | 44 +++---- fs/erofs/zmap.c | 32 ++--- include/trace/events/erofs.h | 14 +-- 15 files changed, 338 insertions(+), 598 deletions(-) -- 2.17.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel