Hi Christoph, On Fri, Aug 30, 2019 at 08:46:50AM -0700, Christoph Hellwig wrote: > On Fri, Aug 30, 2019 at 11:36:42AM +0800, Gao Xiang wrote: > > As Dan Carpenter suggested [1], I have to remove > > all erofs likely/unlikely annotations. > > Do you have to remove all of them, or just those where you don't have > a particularly good reason why you think in this particular case they > might actually matter? I just added unlikely/likely for all erofs error handling paths or rare happened cases at first... (That is all in my thought...) I don't have some benchmark data for each unlikely/likely case (and I have no idea "is that worth to take time to benchmark rather than do another more useful stuffs"), so..I have to kill them all... Thanks, Gao Xiang _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
