Hi Dan, On Thu, Aug 29, 2019 at 06:04:36PM +0300, Dan Carpenter wrote: > On Thu, Aug 29, 2019 at 10:15:22PM +0800, Gao Xiang wrote: > > I am very happy that you send a patch about this, but we have > > to take care of handling "fall through" properly at least, > > and I don't want to introduce some extra compile warnings > > instead at this time. > > I can't apply the patch so I maybe missed something. I don't see > a fall through issue. We have the code so you could use ^^^^^^^^ to > indicate which lines have a fall through problem. > > > > > EROFS is sensitive for now and I have no idea what the "real" > > point is. > > What does "sensitive" mean here? Now that it's out of staging we > aren't applying clean up patches? Of course not, I mean we should avoid "fall through" problem but I have no time to verify this patch since I am fixing what hch said as well. Thanks, Gao Xiang > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
