On Thu, Aug 29, 2019 at 09:56:07PM +0800, Gao Xiang wrote: > Hi Pratik, > > On Thu, Aug 29, 2019 at 06:38:13PM +0530, Pratik Shinde wrote: > > while filling the linux inode, using switch-case statement to check > > the type of inode. > > switch-case statement looks more clean. > > > > Signed-off-by: Pratik Shinde <pratikshinde320@xxxxxxxxx> > > No, that is not the case, see __ext4_iget() in fs/ext4/inode.c. Unnecessary complaining. > and could you write patches based on latest staging tree? > erofs is now in "fs/" rather than "drivers/staging". > and I will review it then. > > p.s. if someone argues here or there, there will be endless > issues since there is no standard at all. More complaining... It doesn't matter if you can find ext4 that looks like dog poop, that's irrelevant. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
