On Wed, Aug 28, 2019 at 12:47:26PM +0200, Johan Hovold wrote: > On Wed, Aug 28, 2019 at 11:28:59AM +0100, Rui Miguel Silva wrote: > > More headers needed to be fixed when moving greybus out of staging and > > enabling the COMPILE_TEST option. > > > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > Signed-off-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx> > > --- > > include/linux/greybus/operation.h | 1 + > > include/linux/greybus/svc.h | 2 ++ > > 2 files changed, 3 insertions(+) > > > > diff --git a/include/linux/greybus/operation.h b/include/linux/greybus/operation.h > > index 8ca864bba23e..bfbc56d8d863 100644 > > --- a/include/linux/greybus/operation.h > > +++ b/include/linux/greybus/operation.h > > @@ -15,6 +15,7 @@ > > #include <linux/types.h> > > #include <linux/workqueue.h> > > > > +#include "hd.h" > > No need to include hd.h, you only need a forward declaration of struct > gb_host_device. > > > struct gb_operation; > > > > diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h > > index 507f8bd4e4c8..11a86504c429 100644 > > --- a/include/linux/greybus/svc.h > > +++ b/include/linux/greybus/svc.h > > @@ -12,6 +12,8 @@ > > #include <linux/types.h> > > #include <linux/device.h> > > > > +#include "greybus_protocols.h" > > Same here, no need to include all the protocol definitions for struct > gb_svc_l2_timer_cfg. I agree with Johan, just forward declare these things and all should be fine and much simpler. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
