I can't compile greybus so it's hard to run Smatch on it... I have a Smatch thing which ignores missing includes and just tries its best. It mostly generates garbage output but a couple of these look like potential issues: drivers/staging/greybus/operation.c:379 gb_operation_message_alloc() warn: check 'message_size' for integer overflows 'kzalloc()' drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->channels' double freed drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->name' double freed regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel