Re: rtl8192u - meaning of TO_DO_LIST?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 22, 2019 at 02:51:46PM -0700, stephen@xxxxxxxxxx wrote:
> Hi all,
> 
> Similar to Colin's question yesterday about the rtl8192u driver, is
> anybody familiar with the TO_DO_LIST define? As I looked through
> checkpatch warnings I saw a particular concerning pattern in
> drivers/staging/rtl8192u/r8192U.h:2183:
> 
> #ifdef TO_DO_LIST
> 	if (Adapter->bInHctTest)
> 		/* long statement here */
> 	else
> #endif
> 	/* unindented statement here */
> 
> It seems this code would break if TO_DO_LIST were defined, and I verified
> that it is the case. I can't find any comment or documentation about what
> the goal of this "to do" item is.
> 
> Does anybody know what this is there for? If not, does it make sense to
> just go ahead and remove the code there?

If the code is dead, just delete it.  That's a very simple rule in
staging.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux