Hi Chuanhong, On Wed, Jul 24, 2019 at 10:23:08AM +0800, Chuanhong Guo wrote: > This commit adds device tree binding documentation for MT7621 > PLL controller. > > Signed-off-by: Chuanhong Guo <gch981213@xxxxxxxxx> > --- > > Change since v1: > drop useless syscon in compatible string > > .../bindings/clock/mediatek,mt7621-pll.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt7621-pll.txt This binding needs review from DT maintainers before I apply it, but as a general note it's typical to add the binding *before* its use in the series. That is, this patch should come before patch 3. Personally I'd squash it with patch 1 so the binding & the header file needed to use the binding are added in one patch, then a later patch actually makes use of them. Thanks, Paul > diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt7621-pll.txt b/Documentation/devicetree/bindings/clock/mediatek,mt7621-pll.txt > new file mode 100644 > index 000000000000..7dcfbd5283e3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/mediatek,mt7621-pll.txt > @@ -0,0 +1,18 @@ > +Binding for Mediatek MT7621 PLL controller > + > +The PLL controller provides the 2 main clocks of the SoC: CPU and BUS. > + > +Required Properties: > +- compatible: has to be "mediatek,mt7621-pll" > +- #clock-cells: has to be one > + > +Optional properties: > +- clock-output-names: should be "cpu", "bus" > + > +Example: > + pll { > + compatible = "mediatek,mt7621-pll"; > + > + #clock-cells = <1>; > + clock-output-names = "cpu", "bus"; > + }; > -- > 2.21.0 > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel