On 2019/7/25 22:49, Greg KH wrote:
> On Thu, Jul 25, 2019 at 10:27:16PM +0800, YueHaibing wrote:
>> use variables 'local_entity_uc' and 'local_uc',
>> mute gcc used-but-set-variable warning:
>>
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_release_internal:
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:16: warning:
>> variable local_entity_uc set but not used [-Wunused-but-set-variable]
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning:
>> variable local_uc set but not used [-Wunused-but-set-variable]
>>
>> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> ---
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> index cc4383d..04e6427 100644
>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> @@ -2861,15 +2861,13 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service)
>> } else {
>> vchiq_log_info(vchiq_susp_log_level,
>> "%s %s count %d, state count %d - suspending",
>> - __func__, entity, *entity_uc,
>> - arm_state->videocore_use_count);
>> + __func__, entity, local_entity_uc, local_uc);
>> vchiq_arm_vcsuspend(state);
>> }
>> } else
>> vchiq_log_trace(vchiq_susp_log_level,
>> "%s %s count %d, state count %d",
>> - __func__, entity, *entity_uc,
>> - arm_state->videocore_use_count);
>> + __func__, entity, local_entity_uc, local_uc);
>
> Are you sure this is the correct way to solve this?
>
> Why not just remove the local variables instead, as obviously they are
> not being used.
It seems they are equivalent
2852 local_uc = --arm_state->videocore_use_count;
2853 local_entity_uc = --(*entity_uc);
However, I will resend as your suggestion. Thanks！
>
> thanks,
>
> greg k-h
>
> .
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
