Am 26.06.2019 um 16:56 schrieb Dan Carpenter:
> Both these patches seem fine.
>
> On Wed, Jun 26, 2019 at 04:28:56PM +0200, Tobias Nießen wrote:
>> This commit uses the fact that
>>
>> if (a) {
>> if (b) {
>> ...
>> }
>> }
>>
>> can instead be written as
>>
>> if (a && b) {
>> ...
>> }
>>
>> without any change in behavior, allowing to decrease the indentation
>> of the contained code block and thus reducing the average line length.
>>
>> Signed-off-by: Tobias Nießen <tobias.niessen@xxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Sabrina Gaube <sabrina-gaube@xxxxxx>
>
> Signed-off-by is like signing a legal document that you didn't put any
> of SCO's secret UNIXWARE source code into your patch or do other illegal
> activities. Everyone who handles a patch is supposed to Sign it.
>
> It's weird to see Sabrina randomly signing your patches. Probably there
> is a more appropriate kind of tag to use as well or instead such as
> Co-Developed-by, Reviewed-by or Suggested-by.
>
> regards,
> dan carpenter
>
Thank you, Dan. This patch series is a mandatory part of a course Sabrina and I are taking at university. We were told to add Signed-off-by for both of us. I can add Co-Developed-by if that helps? Or should she just verify via email that she did indeed sign off?
Regards,
Tobias
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
