Re: [PATCH 1/6] staging: kpc2000_dma: added Kconfig to enable asynchronous I/O.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-06-13, at 10:45:31 +0200, Greg KH wrote:
> On Tue, Jun 11, 2019 at 08:50:59PM +0100, Jeremy Sowden wrote:
> > The DMA driver has call-backs for doing asynchronous I/O which are
> > protected by a CONFIG_ macro which is not defined.  Added a Kconfig
> > stanza to define it.
> >
> > Cc: Matt Sickler <matt.sickler@xxxxxxxxxxxxxx>
> > Signed-off-by: Jeremy Sowden <jeremy@xxxxxxxxxx>
> > ---
> >  drivers/staging/kpc2000/Kconfig           | 8 ++++++++
> >  drivers/staging/kpc2000/kpc_dma/fileops.c | 6 +++---
> >  2 files changed, 11 insertions(+), 3 deletions(-)
>
> This patch breaks the build if you enable the new build option.  So it
> probably should go _after_ you have fixed up the code.
>
> Please fix this series up and resend it.
> Also, is aio even wanted/needed for this driver?  If it's been
> disabled for so long, can't we just delete it if no one is using it?

Matt's recommendation was also to delete it, so I have sent a later
patch to do so.

J.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux