Re: [PATCH] staging: iio: adt7316: Fix build errors when GPIOLIB is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



G'day Fabio,

On 6/06/2019 09:42, Fabio Estevam wrote:
On x86_64 when GPIOLIB is not set the following build errors
are seen:

drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]

These functions are provided by the <linux/gpio/consumer.h>
and <linux/irq.h> headers, so include them to fix these
build errors.

Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
---
  drivers/staging/iio/addac/adt7316.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 37ce563cb0e1..5470a9c3f872 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -7,6 +7,8 @@
#include <linux/interrupt.h>
  #include <linux/gpio.h>
This should be removed as well.
See comment at top of linux/gpio.h



+#include <linux/gpio/consumer.h>
+#include <linux/irq.h>
  #include <linux/workqueue.h>
  #include <linux/device.h>
  #include <linux/kernel.h>



--
Regards
Phil Reid
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux