On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote: > This was reported by sparse: > drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static? > > Signed-off-by: Valerio Genovese <valerio.click@xxxxxxxxx> > --- > drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h > index cdac46a21692..a651686b1787 100644 > --- a/drivers/staging/isdn/hysdn/hysdn_defs.h > +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h > @@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info; > /* exported vars */ > /*****************/ > extern hysdn_card *card_root; /* pointer to first card */ > - > +extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net > > > /*************************/ Shouldn't you also remove it from the place it was devlared as extern? Also, this is code on its way out of the kernel, not a big deal to leave it alone for now. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
