On Wed, May 29, 2019 at 07:15:29PM +0530, Nishka Dasgupta wrote:
> As the function CARDbRadioPowerOff always returns true, and this value
> does not appear to be used anywhere, the return variable can be entirely
> removed and the function converted to type void.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx>
> ---
> drivers/staging/vt6655/card.c | 56 ++++++++++++++++-------------------
> drivers/staging/vt6655/card.h | 2 +-
> 2 files changed, 27 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 6ecbe925026d..2aca5b38be5c 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -409,42 +409,38 @@ bool CARDbSetBeaconPeriod(struct vnt_private *priv,
> * Out:
> * none
> *
> - * Return Value: true if success; otherwise false
> + * Return Value: none
That's obvious and the whole line can be removed.
> */
> -bool CARDbRadioPowerOff(struct vnt_private *priv)
> +void CARDbRadioPowerOff(struct vnt_private *priv)
> {
> - bool bResult = true;
> -
> - if (priv->bRadioOff)
> - return true;
> -
> - switch (priv->byRFType) {
> - case RF_RFMD2959:
> - MACvWordRegBitsOff(priv->PortOffset, MAC_REG_SOFTPWRCTL,
> - SOFTPWRCTL_TXPEINV);
> - MACvWordRegBitsOn(priv->PortOffset, MAC_REG_SOFTPWRCTL,
> - SOFTPWRCTL_SWPE1);
> - break;
> + if (!priv->bRadioOff) {
> + switch (priv->byRFType) {
No, don't do that. Leave the indentation alone and just return "early"
like the code did.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
