On Fri, May 31, 2019 at 02:17:18AM +0530, Nishka Dasgupta wrote: > Remove variable vpfe_dev and replace it with its value (since the > function otherwise uses values directly instead of local variables). This says _what_ you do. But we can see that in the patch itself. You need to say _why_ you are doing this. There's no need for this change at all. Again, as I have said before, we write code for developers to read first, the compiler second. By making these types of changes you are making it harder to read/understand by a developer, and providing absolutely no benifit to the compiler at all. So it's actually making the code worse! not good at all. Please reconsider this type of change, as I keep asking you to. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
