On Fri, May 24, 2019 at 11:22:38AM +0530, Nishka Dasgupta wrote: > The initial value of return variable ret is never used, so it can be > removed. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> > --- > drivers/staging/ks7010/ks_hostif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index e089366ed02a..3775fd4b89ae 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -1067,7 +1067,7 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *skb) > unsigned int length = 0; > struct hostif_data_request *pp; > unsigned char *p; > - int result = 0; > + int result; You should get rid of the result variable completely and just use "ret" instead. No need for two variables. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
