On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote:
> In the functions export_reset_0 and export_reset_1 in arcx-anybus.c,
> the only operation performed before return is passing the variable cd
> (which takes the value of a function call on one of the parameters) as
> argument to another function. Hence the variable cd can be removed.
> Issue found using Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@xxxxxxxxx>
> ---
> drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/fieldbus/anybuss/arcx-anybus.c b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
> index 2ecffa42e561..e245f940a5c4 100644
> --- a/drivers/staging/fieldbus/anybuss/arcx-anybus.c
> +++ b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
> @@ -87,16 +87,12 @@ static int anybuss_reset(struct controller_priv *cd,
>
> static void export_reset_0(struct device *dev, bool assert)
> {
> - struct controller_priv *cd = dev_get_drvdata(dev);
> -
> - anybuss_reset(cd, 0, assert);
> + anybuss_reset(dev_get_drvdata(dev), 0, assert);
> }
While your patch is "correct", it's not the nicest thing. The way the
code looks today is to make it obvious we are passing a pointer to a
struct controller_priv() into anybuss_reset(). But with your change, it
looks like we are passing any random void pointer to it.
So I'd prefer the original code please.
Also, you forgot to cc: Sven on this patch, please always use the output
of scripts/get_maintainer.pl.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
