On Sat, 18 May 2019 19:44:35 -0300
Bárbara Fernandes <barbara.fernandes@xxxxxx> wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@xxxxxx>
> Signed-off-by: Wilson Sales <spoonm@xxxxxxxxxx>
> Co-developed by: Wilson Sales <spoonm@xxxxxxxxxx>
Hi Bárbara, Wilson,
One minor issue inline about code ordering.
Actual content is fine.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 3d74da9d37e7..cc886f944dbf 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> {"ad7195", ID_AD7195},
> {}
> };
> +
> +static const struct of_device_id ad7192_of_spi_match[] = {
> + { .compatible = "adi,ad7190" },
> + { .compatible = "adi,ad7192" },
> + { .compatible = "adi,ad7193" },
> + { .compatible = "adi,ad7195" },
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
> +
Please keep the declaration of the table alongside the relevant
MODULE_DEVICE_TABLE.
In short, better to have your additions after this next line.
> MODULE_DEVICE_TABLE(spi, ad7192_id);
>
> static struct spi_driver ad7192_driver = {
> .driver = {
> .name = "ad7192",
> + .of_match_table = ad7192_of_spi_match,
> },
> .probe = ad7192_probe,
> .remove = ad7192_remove,
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
