On Wed, May 15, 2019 at 11:34:52AM +0100, Jeremy Sowden wrote:
> Fixed the following two sparse warnings by using designated
> initializers:
>
> drivers/staging/kpc2000/kpc2000/cell_probe.c:101:34: warning: Using plain integer as NULL pointer
> drivers/staging/kpc2000/kpc2000/cell_probe.c:364:34: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Jeremy Sowden <jeremy@xxxxxxxxxx>
> ---
> drivers/staging/kpc2000/kpc2000/cell_probe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> index 30e6f176ddfa..9cb745f4323a 100644
> --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> @@ -94,7 +94,7 @@ void parse_core_table_entry(struct core_table_entry *cte, const u64 read_val, co
> static int probe_core_basic(unsigned int core_num, struct kp2000_device *pcard,
> char *name, const struct core_table_entry cte)
> {
> - struct mfd_cell cell = {0};
> + struct mfd_cell cell = { .id = core_num, .name = name };
> struct resource resources[2];
>
> struct kpc_core_device_platdata core_pdata = {
> @@ -315,7 +315,7 @@ static int probe_core_uio(unsigned int core_num, struct kp2000_device *pcard,
>
> static int create_dma_engine_core(struct kp2000_device *pcard, size_t engine_regs_offset, int engine_num, int irq_num)
> {
> - struct mfd_cell cell = {0};
> + struct mfd_cell cell = { .id = engine_num };
> struct resource resources[2];
>
These changes make no sense because we just write over it later.
Maybe you're going to fix it up later in the patch series, perhaps but
that's not how it's done. Each patch should do "one thing", not "half
and thing and then half a thing later in the series possibly (I am
reviewing the patches in order so I don't know)".
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
