Hi Dan, thanks for reviewing.
On Mon, 2019-05-06 at 18:20 +0300, Dan Carpenter wrote:
> On Mon, May 06, 2019 at 04:40:29PM +0200, Nicolas Saenz Julienne wrote:
> > @@ -1740,7 +1740,8 @@ parse_rx_slots(struct vchiq_state *state)
> > &service->bulk_rx : &service->bulk_tx;
> >
> > DEBUG_TRACE(PARSE_LINE);
> > - if (mutex_lock_killable(&service->bulk_mutex)) {
> > + if (mutex_lock_killable(
> > + &service->bulk_mutex) != 0) {
>
> This series does't add != 0 consistently... Personally, I would prefer
> we just leave it out. I use != 0 for two things. 1) When I'm talking
> about the number zero.
>
> if (len == 0) {
>
> Or with strcmp():
>
> if (strcmp(a, b) == 0) { // a equals b
> if (strcmp(a, b) < 0) { // a less than b.
>
> But here zero means no errors, so I would just leave it out...
I agree, I'll fix it.
Regards,
Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
